[libvirt] [PATCH 6/9] tests: qemuxml2xml: Use DO_TEST() for most tests

Andrea Bolognani abologna at redhat.com
Thu Aug 4 13:04:19 UTC 2016


On Thu, 2016-08-04 at 13:09 +0200, Ján Tomko wrote:
> > +    DO_TEST("pci-bridge",
> > +            QEMU_CAPS_DEVICE_PCI_BRIDGE);
> > +    DO_TEST("pci-bridge-many-disks",
> > +            QEMU_CAPS_DEVICE_PCI_BRIDGE);
> > +    DO_TEST("pci-autoadd-addr",
> > +            QEMU_CAPS_DEVICE_PCI_BRIDGE);
> > +    DO_TEST("pci-autoadd-idx",
> > +            QEMU_CAPS_DEVICE_PCI_BRIDGE);
> 
> Now you can fit some of the tests on a single line.

I think always having the caps on a separate line makes it
easier to tell at a glance whether caps are used or not, so
I'd rather leave it the way it is if that's okay with you.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list