[libvirt] [PATCH 3/7] tests: fix the return value of test-wrap-argv

Laine Stump laine at laine.org
Thu Aug 18 05:20:10 UTC 2016


On 08/03/2016 12:20 PM, Ján Tomko wrote:
> The script was returning success unless it failed on the last file.
> This went unnoticed because sc_prohibit_long_lines forbids lines
> longer than 90 characters in .arg[sv] files.
> ---
>   tests/test-wrap-argv.pl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/test-wrap-argv.pl b/tests/test-wrap-argv.pl
> index 2898156..f0d3c0b 100755
> --- a/tests/test-wrap-argv.pl
> +++ b/tests/test-wrap-argv.pl
> @@ -39,8 +39,8 @@ if (@ARGV[0] eq "--in-place") {
>       shift @ARGV;
>   }
>   
> +$ret = 0;
>   foreach my $file (@ARGV) {
> -    $ret = 0;
>       if (&rewrap($file) < 0) {
>           $ret = 1;
>       }


ACK.




More information about the libvir-list mailing list