[libvirt] [PATCH] tools: Don't list virsh-* under EXTRA_DIST

Jiri Denemark jdenemar at redhat.com
Wed Aug 31 11:36:10 UTC 2016


On Wed, Aug 31, 2016 at 12:55:57 +0200, Michal Privoznik wrote:
> When we wanted to break huge and unmaintainable virsh into
> smaller files first thing we did was to just move funcs into
> virsh-.c files and then #include them from virsh. Having it done
> this way we also needed to have them listed under EXTRA_DIST.
> However, things got changed since then and now all the virsh-*.c
> files are proper source files. Therefore they are listed under
> virsh_SOURCES too. But for some reason we forgot to remove them
> from EXTRA_DIST.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tools/Makefile.am | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index a01c58d..e7e42c3 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -64,13 +64,6 @@ EXTRA_DIST = \
>  	libvirt-guests.sysconf				\
>  	virt-login-shell.conf				\
>  	virsh-edit.c					\
> -	virsh-domain.c					\
> -	virsh-domain-monitor.c				\
> -	virsh-host.c virsh-interface.c			\
> -	virsh-network.c virsh-nodedev.c			\
> -	virsh-nwfilter.c virsh-pool.c			\
> -	virsh-secret.c virsh-snapshot.c			\
> -	virsh-volume.c					\
>  	$(PODFILES)					\
>  	$(MANINFILES)					\
>  	$(NULL)

ACK

Jirka




More information about the libvir-list mailing list