[libvirt] [PATCH 0/5] Reject duplicate drive addresses

Michal Privoznik mprivozn at redhat.com
Fri Dec 2 16:28:59 UTC 2016


On 30.11.2016 12:47, Marc Hartmayer wrote:
> Reject duplicate drive addresses at domain definition. Hot-plug for
> disks and hostdevs is still to fix and this is why the old version of
> drive address checking is still there. Additionally, it isn't that
> easy to be sure that the changes won't break other drivers as these
> are common code changes.
> 
> Marc Hartmayer (5):
>   conf: simplify functions virDomainSCSIDriveAddressIsUsedBy*()
>   conf: virDomainDriveAddressIsUsedByDisk: Rename type to bus_type
>   tests: don't use duplicate disk addresses
>   conf: add global check for duplicate drive addresses
>   tests: add test cases for address conflicts
> 
>  src/conf/domain_conf.c                             | 184 +++++++++++++++++----
>  .../qemuxml2argv-disk-drive-address-conflict.xml   |  27 +++
>  ...xml2argv-disk-hostdev-scsi-address-conflict.xml |  30 ++++
>  ...emuxml2argv-hostdevs-drive-address-conflict.xml |  33 ++++
>  .../qemuxml2argv-seclabel-dynamic-override.args    |   4 +-
>  .../qemuxml2argv-seclabel-dynamic-override.xml     |   2 +-
>  tests/qemuxml2argvtest.c                           |   8 +
>  .../qemuxml2xmlout-seclabel-dynamic-override.xml   |   2 +-
>  8 files changed, 251 insertions(+), 39 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-address-conflict.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-hostdev-scsi-address-conflict.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdevs-drive-address-conflict.xml
> 

ACK series. We are currently in freeze so I will push this after the
release. Technically this could go in as it is a bug fix, but rather a
big one so I'd rather push it after the release, if you don't mind.

Michal




More information about the libvir-list mailing list