[libvirt] [PATCH v2 06/10] admin: Introduce virAdmConnectSetLoggingOutputs

John Ferlan jferlan at redhat.com
Fri Dec 9 12:12:38 UTC 2016



On 11/25/2016 08:12 AM, Erik Skultety wrote:
> Enable libvirt users to modify daemon's logging output settings from outside.
> If either an empty string or NULL is passed, a default logging output will be
> used the same way as it would be in case writing an empty string to the
> libvirtd.conf
> 
> Signed-off-by: Erik Skultety <eskultet at redhat.com>
> ---
>  daemon/admin.c                  | 10 ++++++++++
>  include/libvirt/libvirt-admin.h |  4 ++++
>  src/admin/admin_protocol.x      | 12 +++++++++++-
>  src/admin_protocol-structs      |  5 +++++
>  src/libvirt-admin.c             | 38 ++++++++++++++++++++++++++++++++++++++
>  src/libvirt_admin_private.syms  |  1 +
>  src/libvirt_admin_public.syms   |  1 +
>  7 files changed, 70 insertions(+), 1 deletion(-)
> 

[...]

> diff --git a/src/libvirt_admin_public.syms b/src/libvirt_admin_public.syms
> index 234c50e..d4713da 100644
> --- a/src/libvirt_admin_public.syms
> +++ b/src/libvirt_admin_public.syms
> @@ -44,4 +44,5 @@ LIBVIRT_ADMIN_2.5.0 {
>      global:
>          virAdmConnectGetLoggingOutputs;
>          virAdmConnectGetLoggingFilters;
> +        virAdmConnectSetLoggingOutputs;
>  } LIBVIRT_ADMIN_2.0.0;
> 

s/2.5.0/3.0.0

Of course makes me think "eventually" would someone want or find it
useful to have "Add" or "Remove" options too rather than just wholesale
replacement... Maybe it's just the fresh coffee talking.

ACK

John




More information about the libvir-list mailing list