[libvirt] [PATCH 05/89] m4/virt: use LIBVIRT_RESULT macro instead of AC_MSG_NOTICE

Jiri Denemark jdenemar at redhat.com
Fri Dec 16 20:23:27 UTC 2016


On Fri, Dec 16, 2016 at 10:10:33 +0100, Pavel Hrdina wrote:
> The LIBVIRT_RESULT does a nice formatting of the output and ensures
> that the format is unified.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  m4/virt-driver-bhyve.m4 | 2 +-
>  m4/virt-driver-uml.m4   | 2 +-
>  m4/virt-driver-vz.m4    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/m4/virt-driver-bhyve.m4 b/m4/virt-driver-bhyve.m4
> index bbdd8b2f0f..11d3a667ee 100644
> --- a/m4/virt-driver-bhyve.m4
> +++ b/m4/virt-driver-bhyve.m4
> @@ -56,5 +56,5 @@ dnl Build with gnulib's getopt which contains a reentrant interface
>  AC_DEFUN([gl_REPLACE_GETOPT_ALWAYS], [])
>  
>  AC_DEFUN([LIBVIRT_DRIVER_RESULT_BHYVE],[
> -    AC_MSG_NOTICE([    Bhyve: $with_bhyve])
> +    LIBVIRT_RESULT([Bhyve], [$with_bhyve])
>  ])
...

Incomplete. Most of the places where AC_MSG_NOTICE is still used after
this patch are fixed in later patches, but even after applying all 89
patches, there are still some places where LIBVIRT_RESULT should be
used:

AC_MSG_NOTICE([         Coverage: $enable_coverage])
AC_MSG_NOTICE([        Alloc OOM: $enable_oom])
AC_MSG_NOTICE([       Use -Werror: $enable_werror])
AC_MSG_NOTICE([     Warning Flags: $WARN_CFLAGS])
AC_MSG_NOTICE([ Char device locks: $with_chrdev_lock_files])
AC_MSG_NOTICE([             Debug: $enable_debug])
AC_MSG_NOTICE([    Default Editor: $with_default_editor])
AC_MSG_NOTICE([            DTrace: $with_dtrace])
AC_MSG_NOTICE([virt-host-validate: $with_host_validate])
AC_MSG_NOTICE([       Init script: $with_init_script])
AC_MSG_NOTICE([      Loader/NVRAM: $with_loader_nvram])
AC_MSG_NOTICE([  virt-login-shell: $with_login_shell])
AC_MSG_NOTICE([             numad: $with_numad])
AC_MSG_NOTICE([       XML Catalog: $with_xml_catalog_file])

Jirka




More information about the libvir-list mailing list