[libvirt] [PATCH 17/89] configure: move with-driver-modules check to its own file

Jiri Denemark jdenemar at redhat.com
Mon Dec 19 15:35:42 UTC 2016


On Fri, Dec 16, 2016 at 10:10:45 +0100, Pavel Hrdina wrote:
> Rename DRIVER_MODULE_(LDFLAGS|LIBS|CFLAGS) to unify the naming.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  configure.ac              | 39 ++++---------------------------
>  m4/virt-driver-modules.m4 | 58 +++++++++++++++++++++++++++++++++++++++++++++++
>  src/Makefile.am           |  2 +-
>  3 files changed, 63 insertions(+), 36 deletions(-)
>  create mode 100644 m4/virt-driver-modules.m4
...
> diff --git a/src/Makefile.am b/src/Makefile.am
> index b713787288..49abcf25d2 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -42,7 +42,7 @@ AM_CFLAGS =	$(LIBXML_CFLAGS)				\
>  		$(LOCK_CHECKING_CFLAGS)				\
>  		$(WIN32_EXTRA_CFLAGS)				\
>  		$(COVERAGE_CFLAGS)
> -AM_LDFLAGS =	$(DRIVER_MODULE_LDFLAGS)			\
> +AM_LDFLAGS =	$(DRIVER_MODULES_LDFLAGS)			\
>  		$(COVERAGE_LDFLAGS)				\
>  		$(RELRO_LDFLAGS)				\
>  		$(NO_INDIRECT_LDFLAGS)				\

You forgot to change DRIVER_MODULE_LIBS in

libvirt_la_LIBADD += \
		    $(DRIVER_MODULE_LIBS) \
		    $(CYGWIN_EXTRA_LIBADD)

ACK with this fix.

Jirka




More information about the libvir-list mailing list