[libvirt] [PATCH 19/89] configure: move polkit check to its own file

[Jiri Denemark]

On Fri, Dec 16, 2016 at 10:10:47 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  configure.ac      |  83 ++----------------------------------------
>  m4/virt-polkit.m4 | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 110 insertions(+), 80 deletions(-)
>  create mode 100644 m4/virt-polkit.m4
...
> diff --git a/m4/virt-polkit.m4 b/m4/virt-polkit.m4
> new file mode 100644
> index 0000000000..206fc4a39d
> --- /dev/null
> +++ b/m4/virt-polkit.m4
> @@ -0,0 +1,107 @@
> +AC_DEFUN([LIBVIRT_CHECK_POLKIT], [
> +  AC_REQUIRE([LIBVIRT_CHECK_DBUS])
> +
> +  POLKIT_REQUIRED="0.6"
> +  POLKIT_CFLAGS=
> +  POLKIT_LIBS=
> +  PKCHECK_PATH=
> +
> +  with_polkit0=no
> +  with_polkit1=no
> +
> +  if test "x$with_polkit" = "xyes" || test "x$with_polkit" = "xcheck"; then
> +    dnl Check for new polkit first. We directly talk over DBus
> +    dnl but we use existence of pkcheck binary as a sign that
> +    dnl we should prefer polkit-1 over polkit-0, so we check
> +    dnl for it even though we don't ultimately use it
> +    AC_PATH_PROG([PKCHECK_PATH], [pkcheck], [], [/usr/sbin:$PATH])

The original code used $LIBVIRT_SBIN_PATH which is set to
$PATH:/sbin:/usr/sbin:/usr/local/sbin while here you use
/usr/sbin:$PATH. Was it intentional? I believe it wasn't since other
code you moved (m4/virt-external-programs.m4 still uses
$LIBVIRT_SBIN_PATH).

ACK if you fix this.

Jirka