[libvirt] [PATCH v2 01/21] cgroup: Clean up virCgroupGetPercpuStats

Ján Tomko jtomko at redhat.com
Mon Feb 1 15:15:01 UTC 2016


On Fri, Jan 29, 2016 at 05:01:56PM +0100, Peter Krempa wrote:
> Use 'ret' for return variable name, clarify use of 'param_idx' and avoid
> unnecessary 'success' label. No functional changes. Also document the
> function.
> ---
> 
> Notes:
>     V2:
>     - Fixed mistake in the refactor that would return incorrect error values (Found by Jan)
>     - Added comment explaining the terriblenes of the function (Requested by John)
> 
>  src/util/vircgroup.c | 64 +++++++++++++++++++++++++++++++++++-----------------
>  1 file changed, 43 insertions(+), 21 deletions(-)
> 

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160201/c0fd7602/attachment-0001.sig>


More information about the libvir-list mailing list