[libvirt] [PATCH 2/3] libxl: remove check duplicates

John Ferlan jferlan at redhat.com
Mon Feb 1 22:49:46 UTC 2016



On 01/15/2016 09:05 AM, Nikolay Shirokovskiy wrote:
> virDomainLiveConfigHelperMethod function checks this
> condition already.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---
>  src/libxl/libxl_driver.c | 6 ------
>  1 file changed, 6 deletions(-)
> 

This one seems reasonable and true.

John

> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index 508bae4..7b5c7bc 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -2306,12 +2306,6 @@ libxlDomainPinVcpuFlags(virDomainPtr dom, unsigned int vcpu,
>      if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0)
>          goto cleanup;
>  
> -    if ((flags & VIR_DOMAIN_AFFECT_LIVE) && !virDomainObjIsActive(vm)) {
> -        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
> -                       _("domain is inactive"));
> -        goto endjob;
> -    }
> -
>      if (virDomainLiveConfigHelperMethod(cfg->caps, driver->xmlopt, vm,
>                                          &flags, &targetDef) < 0)
>          goto endjob;
> 




More information about the libvir-list mailing list