[libvirt] [PATCH 3/4] storageVolCreateXML: Swap order of two operations

Erik Skultety eskultet at redhat.com
Fri Feb 12 13:47:14 UTC 2016



On 10/02/16 17:28, Michal Privoznik wrote:
> Firstly, we realloc internal list to hold new item (=volume that
> will be potentially be created) and then we check whether we

s/\(potentially\)\@<= be//

If I screwed up the positive lookbehind just remove the second "be" :)

> actually know how to create it. If we don't we consume more
> memory than we really need for no good reason.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/storage/storage_driver.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
...
ACK

Erik




More information about the libvir-list mailing list