[libvirt] [PATCH v4 0/7] admin: Introduce server listing API

Michal Privoznik mprivozn at redhat.com
Tue Feb 16 16:18:55 UTC 2016


On 12.02.2016 11:08, Erik Skultety wrote:
> Since v3:
> - refactors to virHashForEach and hash iterators
> - servers are now stored in a hash table instead of an array
> - added forgotten virObjectLock in remoteAdminConnectListServers
> 
> Erik Skultety (7):
>   util: Add a return value to void hash iterators
>   util: Refactor virHashForEach so it returns as soon as an iterator
>     fails
>   virnetdaemon: Store servers in a hash table
>   admin: Move admin_server.{h,c} to admin.{h,c}
>   admin: Introduce virAdmServer structure
>   admin: Introduce adminDaemonConnectListServers API
>   virt-admin: Introduce cmdSrvList
> 
>  daemon/Makefile.am                                 |   5 +-
>  daemon/admin.c                                     | 181 +++++++++++++++
>  daemon/admin.h                                     |  36 +++
>  daemon/admin_server.c                              | 111 +++-------
>  daemon/admin_server.h                              |  26 +--
>  daemon/libvirtd.c                                  |   6 +-
>  include/libvirt/libvirt-admin.h                    |  25 ++-
>  po/POTFILES.in                                     |   3 +-
>  src/admin/admin_protocol.x                         |  26 ++-
>  src/admin/admin_remote.c                           |  71 ++++++
>  src/admin_protocol-structs                         |  15 ++
>  src/conf/network_conf.c                            |  15 +-
>  src/conf/nwfilter_params.c                         |   8 +-
>  src/conf/snapshot_conf.c                           |  31 +--
>  src/conf/virchrdev.c                               |   7 +-
>  src/conf/virdomainobjlist.c                        |  17 +-
>  src/datatypes.c                                    |  35 +++
>  src/datatypes.h                                    |  38 ++++
>  src/libvirt-admin.c                                |  79 +++++++
>  src/libvirt_admin_private.syms                     |   5 +
>  src/libvirt_admin_public.syms                      |   3 +
>  src/locking/lock_daemon.c                          |  10 +-
>  src/logging/log_daemon.c                           |   3 +-
>  src/lxc/lxc_controller.c                           |   2 +-
>  src/nwfilter/nwfilter_dhcpsnoop.c                  |   3 +-
>  src/nwfilter/nwfilter_gentech_driver.c             |   5 +-
>  src/qemu/qemu_domain.c                             |   7 +-
>  src/qemu/qemu_domain.h                             |   6 +-
>  src/qemu/qemu_driver.c                             |  13 +-
>  src/rpc/virnetdaemon.c                             | 225 +++++++++++++------
>  src/rpc/virnetdaemon.h                             |   8 +-
>  src/test/test_driver.c                             |  14 +-
>  src/uml/uml_driver.c                               |  13 +-
>  src/util/virclosecallbacks.c                       |   9 +-
>  src/util/virhash.c                                 |  28 ++-
>  src/util/virhash.h                                 |   6 +-
>  src/xen/xm_internal.c                              |   7 +-
>  tests/virhashtest.c                                |  54 +++--
>  .../input-data-admin-server-names.json             | 129 +++++++++++
>  .../virnetdaemondata/output-data-admin-nomdns.json |   8 +-
>  .../output-data-admin-server-names.json            | 126 +++++++++++
>  .../virnetdaemondata/output-data-anon-clients.json |   6 +-
>  .../output-data-initial-nomdns.json                |   6 +-
>  tests/virnetdaemondata/output-data-initial.json    |   6 +-
>  .../output-data-no-keepalive-required.json         | 242 +++++++++++----------
>  tests/virnetdaemontest.c                           |  63 +++---
>  tools/virt-admin.c                                 |  61 ++++++
>  47 files changed, 1361 insertions(+), 442 deletions(-)
>  create mode 100644 daemon/admin.c
>  create mode 100644 daemon/admin.h
>  create mode 100644 tests/virnetdaemondata/input-data-admin-server-names.json
>  create mode 100644 tests/virnetdaemondata/output-data-admin-server-names.json
> 


ACK series modulo 6/7 as I have some questions there.

Michal




More information about the libvir-list mailing list