[libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

Martin Kletzander mkletzan at redhat.com
Tue Feb 23 14:28:11 UTC 2016


On Tue, Feb 23, 2016 at 12:52:38PM +0100, Ján Tomko wrote:
>On Mon, Feb 22, 2016 at 11:29:54AM +0100, Martin Kletzander wrote:
>> Checking whether x > 0 before looping over [0..x] items doesn't make
>> sense and multi-line body must have curly brackets around it.
>
>Please don't mix cosmetic and functional changes.
>
>Jan
>

None of the changes were functional in this case, so I think it's quite
fine on this particular occasion.

>> Best viewed with '-w'.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  src/conf/domain_conf.c            | 24 +++++++++++++-------
>>  src/qemu/qemu_capabilities.c      | 30 ++++++++++++------------
>>  src/storage/storage_backend_rbd.c | 48 +++++++++++++++++++--------------------
>>  src/vbox/vbox_common.c            | 14 ++++--------
>>  4 files changed, 58 insertions(+), 58 deletions(-)
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160223/bec8f456/attachment-0001.sig>


More information about the libvir-list mailing list