[libvirt] [PATCH 05/10] tests: use virtTestDifferenceFull in tests where we have output file

[Cole Robinson]

On 01/08/2016 08:21 AM, Peter Krempa wrote:
>>  
>>      if (STRNEQ(expectxml, actualxml)) {
>> -        virtTestDifference(stderr, expectxml, actualxml);
>> +        virtTestDifferenceFull(stderr, expectxml, xml, actualxml, NULL);
>>          goto fail;
>>      }
>>
> 
> I'm specially worried about this one since the argv parser is very old
> and obsolete. I'd rather prefer if the regexes that postprocess the
> output were tweaked or othe code mocked so that it gives deterministic
> results at this point before this code is used.
> 

Have we officially marked the argv parser as obsolete? News to me, but welcome
IMO since it's a lot of rarely used code that's never been exhaustively
covered. Always seemed like something that would be better suited as an
external tool (written in a higher level language) since outside of probing
qemu features it has very little overlap with the rest of libvirt.

- Cole