[libvirt] [PATCH 0/4] Adjustment to recent cgroup/cpuset changes

John Ferlan jferlan at redhat.com
Fri Jan 8 16:48:19 UTC 2016


The problem being resolved by this series was seen as a failure in the
virt-test 'memtune' test which attempts to look at the on disk change
for the cgroup by using the 'memory' controller entry in /proc/$pid/cgroup.

For reasons still not quite 100% crystal clear, without doing the revert
in patch#3 of this series, the /proc/$pid/cgroup file gets updated with
the controller path. On the somewhat older f20 test system, this resulted
in an adjustment to other controllers (memory, devices, and blkio). On
a different test environment (f23), the file wasn't erroneously updated.
Although systemd may ultimately be at fault - it just wasn't obvious
what the failure was - so reverting the patch and making the one change
(in patch #4) that appeared to at least follow the spirit of the
reverted patch with respect to using virCgroupAddTask for the
qemuSetupCgroupForEmulator similar to how qemuSetupCgroupForVcpu
does it for the various vpcu threads.

John Ferlan (4):
  cgroup: Fix possible bug as a result of code motion for vcpu cgroup
    setup
  qemu: Add check for NULL cgroup return from virCgroupNewMachine
  Revert "qemu: do not put a task into machine cgroup"
  qemu: Put the emulator cgroup pid into the right task file

 src/qemu/qemu_cgroup.c  | 18 +++++++++++++-----
 src/qemu/qemu_process.c | 12 ++++++------
 2 files changed, 19 insertions(+), 11 deletions(-)

-- 
2.5.0




More information about the libvir-list mailing list