[libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

Andrea Bolognani abologna at redhat.com
Mon Jan 11 12:28:33 UTC 2016


On Mon, 2016-01-11 at 13:21 +0100, Andrea Bolognani wrote:
> On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote:
> > Rather than continually cut-n-paste the strings into each command,
> > create a common macro to be used generically.  Note that not all
> > '{.name = "config",' entries are replaced, just those that have the
> > common .help string of "affect next boot".
>> > Non replaced instances are unique to the command.
> 
> The config option for the 'schedinfo' and 'change-media'
> commands, while it has a slightly different help text, also
> serves AFAICT the same purpose and as such should IMHO use the
> macro you just defined as well.

To expand, I realize that doing so would go against the first
paragraph in your commit message; on the other hand, I believe
*not* doing so would go against the second one, as the slightly
different help string was probably a mistake to begin with when
the options do the exact same thing :)

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list