[libvirt] [PATCH 0/7] Per domain bandwidth settings

[Alexander Burluka]

You are absolutely right, this patchset allows to set domain top-level
cpu.cfs_period_us and cpu.cfs_quota_us cgroups. Can you please
explain problem case a little bit more detailed? This code does not
affect top-level cpuset cgroup, only quota and period, so there is no
visible troubles for me. Thank you!

On 01/12/2016 08:30 PM, Michal Privoznik wrote:
> On 12.01.2016 17:42, Alexander Burluka wrote:
>> We decide to make a global per domain bandwidth setting
>> as were discussed in mailing list earlier.
>> This patchset implements hierarchy top level cpu.cfs_period_us
>> and cpu.cfs_quota_us control knob. I've named this parameters
>> as global_period and global_quota.
>>
>> Alexander Burluka (7):
>>    Add global period definitions
>>    Add global quota parameter necessary definitions
>>    Add error checking on global quota and period
>>    Add new cgroup thread type
>>    Rename qemuSetupCgroupVcpuBW to qemuSetupBandwidthCgroup
>>    Implement qemuSetupGlobalCpuCgroup
>>    Implement handling of per-domain bandwidth settings
>>
>>   docs/schemas/domaincommon.rng    |  10 ++++
>>   include/libvirt/libvirt-domain.h |  32 ++++++++++
>>   src/conf/domain_conf.c           |  37 ++++++++++++
>>   src/conf/domain_conf.h           |   2 +
>>   src/qemu/qemu_cgroup.c           |  78 +++++++++++++++++++++---
>>   src/qemu/qemu_cgroup.h           |   7 ++-
>>   src/qemu/qemu_command.c          |   3 +-
>>   src/qemu/qemu_driver.c           | 125 +++++++++++++++++++++++++++++++++++++--
>>   src/qemu/qemu_process.c          |   4 ++
>>   src/util/vircgroup.c             |   4 ++
>>   src/util/vircgroup.h             |   1 +
>>   11 files changed, 287 insertions(+), 16 deletions(-)
>>
> Similarly to Laine, I have not went through the patches in detail, but
> does this patch set touch the domain top-level cgroup? If so we may be
> in trouble the minute we want to pin the vcpus elsewhere - if it is
> touching the cpuset cgroup too.
>
> Michal

-- 
Regards,
Alexander Burluka