[libvirt] [PATCH 2/2] util: reset MAC address of macvtap passthrough physdev after disassociate

Pavel Hrdina phrdina at redhat.com
Fri Jan 22 13:24:38 UTC 2016


On Thu, Jan 21, 2016 at 02:54:11PM -0500, Laine Stump wrote:
> libvirt always resets the MAC address of the physdev used for macvtap
> passthrough when the guest is finished with it. This was happening
> prior to the 802.1Qb[gh] DISASSOCIATE command, and was quite often
> failing, presumably because the driver wouldn't allow the MAC address
> to be reset while the association was still active, with a log message
> like this:
> Cc: Tony Krowiak <akrowiak at linux.vnet.ibm.com> 
> Cc: Christian Benvenuti <benve at cisco.com>
> 
> virNetDevSetMAC:168 : Cannot set interface MAC to 00:00:00:00:00:00 on 'eth13': Cannot assign requested address
> 
> This patch changes the order - we now do the 802.1Qb[gh] disassociate
> and delete the macvtap interface first, and then reset the MAC
> address.
> ---
>  src/util/virnetdevmacvlan.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

ACK




More information about the libvir-list mailing list