[libvirt] [PATCH v4] qemu: Connect to guest agent iff needed

Michal Privoznik mprivozn at redhat.com
Mon Jan 25 11:20:13 UTC 2016


On 18.01.2016 11:54, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1293351
> 
> Since we already have virtio channel events, we know when guest
> agent within guest has (dis-)connected. Instead of us blindly
> connecting to a socket that no one is listening to, we can just
> follow what qemu-ga does. This has a nice benefit that we don't
> need to 'guest-ping' the agent just to timeout and find out
> nobody is listening.
> 
> The way that this commit is implemented:
> - don't connect in qemuProcessStart directly, defer that to event
>   callback (which already follows the agent).
> - after migration is settled, before we resume vCPUs, ask qemu
>   whether somebody is listening on the socket and if so, connect
>   to it.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> 
> diff to v3:
> -Move cap detection into qemuConnectAgent
> 
>  src/qemu/qemu_driver.c    | 13 ++++++++++++-
>  src/qemu/qemu_migration.c | 12 ++++++++++++
>  src/qemu/qemu_process.c   | 24 ++++++++++++++++++++++++
>  3 files changed, 48 insertions(+), 1 deletion(-)

ping

Michal




More information about the libvir-list mailing list