[libvirt] [PATCH] gendispatch: Don't output spaces on empty line
Jiri Denemark
jdenemar at redhat.com
Thu Jan 28 14:37:20 UTC 2016
On Thu, Jan 28, 2016 at 15:23:56 +0100, Michal Privoznik wrote:
> In our generator for some code we put empty lines in the output
> to separate some blocks of code. However, in some cases we put
> couple of spaces on the empty line too. It's not bug, it just
> isn't nice.
Too many "some" :-)
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> src/rpc/gendispatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl
> index 5cfc512..3740130 100755
> --- a/src/rpc/gendispatch.pl
> +++ b/src/rpc/gendispatch.pl
> @@ -677,7 +677,7 @@ elsif ($mode eq "server") {
> push(@prepare_ret_list,
> "if (VIR_ALLOC($2_p) < 0)\n" .
Looks like the spaces should have been here, in front of "if".
> " goto cleanup;\n" .
> - " \n" .
> + "\n" .
> " if (VIR_STRDUP(*$2_p, $2) < 0)\n".
> " goto cleanup;\n");
ACK
Jirka
More information about the libvir-list
mailing list