[libvirt] [PATCH] virCommandExec: Report error if execve fails

Martin Kletzander mkletzan at redhat.com
Mon Jul 11 15:42:41 UTC 2016


On Mon, Jul 11, 2016 at 04:11:22PM +0200, Michal Privoznik wrote:
>In an unlikely event of execve() failing, the virCommandExec()
>function does not report any error, even though checks that are
>at the beginning of the function are verbose when failing.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/util/vircommand.c |  7 +++++-
> tests/commandtest.c   | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 75 insertions(+), 1 deletion(-)
>

Looks good, but the tests sometimes fails on me with "Child should have
returned an error".  You might want to investigate that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160711/7f9ba870/attachment-0001.sig>


More information about the libvir-list mailing list