[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] tools: Fix usage of incorrect environment variables



On 28/07/16 13:49, Martin Kletzander wrote:
> On Thu, Jul 28, 2016 at 01:18:03PM +0200, Erik Skultety wrote:
>> According to https://bugzilla.redhat.com/show_bug.cgi?id=1357363, most of
>> virt-admin's environment variables are not taken into effect when set.
>> As it
>> turned out, virsh suffers from the very same problem which resides in the
>> generic vsh.c module.
>>
>> Erik Skultety (2):
>>  vsh: Make vshInitDebug return int instead of void
>>  tools: Make use of the correct environment variables
>>
> 
> ACK series && SFF (safe for freeze)
> 
>> tools/virsh.c      |  1 +
>> tools/virt-admin.c |  1 +
>> tools/vsh.c        | 34 +++++++++++++++++++---------------
>> tools/vsh.h        |  1 +
>> 4 files changed, 22 insertions(+), 15 deletions(-)
>>
>> -- 
>> 2.5.5
>>
>> -- 
>> libvir-list mailing list
>> libvir-list redhat com
>> https://www.redhat.com/mailman/listinfo/libvir-list
> 
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

Pushed now. Thanks for review.

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]