[libvirt] [PATCH 1/5] Move struct elem out of virNetDevGetFeatures

Ján Tomko jtomko at redhat.com
Mon Jun 6 14:37:15 UTC 2016


On Mon, Jun 06, 2016 at 04:25:02PM +0200, Peter Krempa wrote:
> On Mon, Jun 06, 2016 at 09:39:24 +0200, Ján Tomko wrote:
> > Rename struct elem to ethtool_to_virnetdev_feature and move it
> > out of the function to allow reusing it.
> > ---
> >  src/util/virnetdev.c | 13 +++++++------
> >  1 file changed, 7 insertions(+), 6 deletions(-)
> > 
> > diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
> > index 7db4497..354e6f7 100644
> > --- a/src/util/virnetdev.c
> > +++ b/src/util/virnetdev.c
> > @@ -3239,6 +3239,11 @@ virNetDevSendEthtoolIoctl(const char *ifname, void *cmd)
> >      return ret;
> >  }
> >  
> > +struct ethtool_to_virnetdev_feature {
> 
> This name is very unorthodox.
> 
> ACK to this patch if you choose a more compliant name.

How about virNetDevEthtoolFeatureCmd?

Jan




More information about the libvir-list mailing list