[libvirt] [PATCH v2 0/6] Introducing storage pool lifecycle event APIs

Cole Robinson crobinso at redhat.com
Tue Jun 14 11:15:27 UTC 2016


On 06/14/2016 02:09 AM, Peter Krempa wrote:
> On Mon, Jun 13, 2016 at 13:35:04 -0400, Cole Robinson wrote:
>> On 06/13/2016 12:38 PM, Jovanka Gulicoska wrote:
> 
> [...]
> 
>>
>> I just reviewed the diff between v1 and v2 and made a couple small changes,
>> diff attached. I copied the docstring from the network events since your
>> version still had several typos, and fixed one spacing issue in comments in
>> the test driver. Otherwise it looks like all my review bits were addressed, so
>> this looks good to me.
>>
>> Let's give it some time to see if anyone else has comments, otherwise I'll
>> push it at the end of the week (with those minor changes)
> 
> Apart from needing to make sure that this series passes 'make check' and
> the few nits pointed out through the code there's one thing that should
> be added. Every event implementation has a virsh command allowing to
> watch them and the virsh change is still missing. It's okay to add it
> later but it should be in this release.
> 

Also, where/how does 'make check' fail for you? Neither it nor 'make
syntax-check' show any error for me.

Thanks,
Cole




More information about the libvir-list mailing list