[libvirt] [PATCH] conf: limit chassisNr, and busNr to a minimum value of 1, not 0

Michal Privoznik mprivozn at redhat.com
Tue Jun 21 07:54:46 UTC 2016


On 20.06.2016 21:03, Laine Stump wrote:
> In the case of chassisNr (used to set chassis_nr of a pci-bridge
> controller), 0 is reserved for / used by the pci[e]-root bus. In the
> base of busNr, a value of 0 would mean that the root bus had no places
> available to plug in new buses, including the pxb itself (the
> documentation I wrote for pxb even noted the limit of busNr as 1.254).
> 
> NB: oddly, the "chassis" attribute, which is used for pcie-root-port
> and pcie-switch-downstream-port *can* be set to 0, since it's the
> combination of {chassis, slot} that needs to be unique, not chassis by
> itself (and slot 0 of pcie-root is reserved, while pcie-*-port can use
> *only* slot 0).
> 
> This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1342962
> ---
>  docs/formatdomain.html.in | 2 +-
>  src/conf/domain_conf.c    | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)

ACK

Michal




More information about the libvir-list mailing list