[libvirt] [PATCH 01/19] storage: Adjust qemu-img switches check

Peter Krempa pkrempa at redhat.com
Tue Jun 21 13:58:06 UTC 2016


On Mon, Jun 13, 2016 at 20:27:40 -0400, John Ferlan wrote:
> Since we support QEMU 0.12 and later, checking for support of specific flags
> added prior to that isn't necessary.
> 
> Thus start with the base of having the "-o options" available for the
> qemu-img create option and then determine whether we have the compat
> option for qcow2 files (which would be necessary up through qemu 2.0
> where the default changes to compat 0.11).
> 
> Adjust test to no long check for NONE and FLAG options as well was removing
> results of tests that would use that option.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/storage/storage_backend.c                      | 91 +++++++---------------
>  tests/storagevolxml2argvdata/qcow2-flag.argv       |  2 -
>  .../qcow2-nobacking-convert-flag.argv              |  2 -
>  .../qcow2-nobacking-convert-none.argv              |  2 -
>  .../qcow2-nobacking-flag.argv                      |  1 -
>  .../qcow2-nobacking-none.argv                      |  1 -
>  tests/storagevolxml2argvdata/qcow2-none.argv       |  1 -
>  tests/storagevolxml2argvtest.c                     | 22 +-----
>  8 files changed, 29 insertions(+), 93 deletions(-)
>  delete mode 100644 tests/storagevolxml2argvdata/qcow2-flag.argv
>  delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-convert-flag.argv
>  delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-convert-none.argv
>  delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-flag.argv
>  delete mode 100644 tests/storagevolxml2argvdata/qcow2-nobacking-none.argv
>  delete mode 100644 tests/storagevolxml2argvdata/qcow2-none.argv

I still think the code should be refactored sooner or later, but ACK.




More information about the libvir-list mailing list