[libvirt] [PATCH 06/17] Use for instead of code duplication when parsing USB port

Peter Krempa pkrempa at redhat.com
Tue Jun 21 15:51:46 UTC 2016


On Fri, Jun 17, 2016 at 20:07:08 +0200, Ján Tomko wrote:
> We are done if the string ends and move to another nesting
> level if we find a dot.
> ---
>  src/conf/device_conf.h |  3 +++
>  src/conf/domain_conf.c | 19 +++++++++++--------
>  2 files changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h
> index 847564b..4903839 100644
> --- a/src/conf/device_conf.h
> +++ b/src/conf/device_conf.h
> @@ -118,6 +118,9 @@ typedef struct _virDomainDeviceCcidAddress {
>      unsigned int slot;
>  } virDomainDeviceCcidAddress, *virDomainDeviceCcidAddressPtr;
>  
> +/* chosen by fair dice roll */

Remove this line.

> +# define VIR_DOMAIN_DEVICE_USB_MAX_PORT_DEPTH 4
> +
>  typedef struct _virDomainDeviceUSBAddress {
>      unsigned int bus;
>      char *port;

ACK




More information about the libvir-list mailing list