[libvirt] [PATCH 07/28] lxc: eliminate extraneous free of netDef->ifname_guest

John Ferlan jferlan at redhat.com
Thu Jun 23 21:24:24 UTC 2016



On 06/22/2016 01:37 PM, Laine Stump wrote:
> lxcContainerRenameAndEnableInterfaces() isn't making a copy of the
> interface's ifname_guest (into newname), it's just copying the pointer
> to it. This means that when it later calls VIR_FREE(newname), it's
> actually freeing up (and fortunately NULLing out, so at least we don't
> try to access free'd memory) netDef->ifname_guest.
> ---
>  src/lxc/lxc_container.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 

ACK

John




More information about the libvir-list mailing list