[libvirt] [PATCH v3 03/10] util: Add 'usage' for encryption

[Ján Tomko]

On Fri, Jun 24, 2016 at 04:53:32PM -0400, John Ferlan wrote:
>In order to use more common code and set up for a future type, modify the
>encryption secret to allow the "usage" attribute or the "uuid" attribute
>to define the secret. The "usage" in the case of a volume secret would be
>the path to the volume.

s/would/could/?

IIUC it can be an arbitrary string.

>
>This code will make use of the virSecretLookup{Parse|Format}Secret common code.
>
>Signed-off-by: John Ferlan <jferlan at redhat.com>
>---
> docs/formatstorageencryption.html.in               | 12 +++++---
> docs/schemas/storagecommon.rng                     | 11 +++++--
> src/qemu/qemu_process.c                            | 13 +++-----
> src/storage/storage_backend.c                      |  3 +-
> src/storage/storage_backend_fs.c                   |  3 +-
> src/util/virstorageencryption.c                    | 26 ++++++----------
> src/util/virstorageencryption.h                    |  3 +-
> .../qemuxml2argv-encrypted-disk-usage.args         | 24 +++++++++++++++
> .../qemuxml2argv-encrypted-disk-usage.xml          | 36 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c                           |  1 +
> .../qemuxml2xmlout-encrypted-disk-usage.xml        |  1 +
> tests/qemuxml2xmltest.c                            |  1 +
> 12 files changed, 98 insertions(+), 36 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk-usage.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-encrypted-disk-usage.xml
> create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-encrypted-disk-usage.xml
>

ACK

Jan