[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: enalbe hotplugging of macvtap device with multiqueue



On 26.02.2016 08:02, Shanzhi Yu wrote:
> in commit 81a110, multiqueue for macvtap is enabled but forget
> to support hotplugging enabled
> 
> Signed-off-by: Shanzhi Yu <shyu redhat com>
> ---
>  src/qemu/qemu_hotplug.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
> index dc76268..b580283 100644
> --- a/src/qemu/qemu_hotplug.c
> +++ b/src/qemu/qemu_hotplug.c
> @@ -892,10 +892,11 @@ int qemuDomainAttachNetDevice(virConnectPtr conn,
>          goto cleanup;
>      }
>  
> -    /* Currently nothing besides TAP devices supports multiqueue. */
> +    /* Currently only TAP/macvtap devices supports multiqueue. */
>      if (net->driver.virtio.queues > 0 &&
>          !(actualType == VIR_DOMAIN_NET_TYPE_NETWORK ||
> -          actualType == VIR_DOMAIN_NET_TYPE_BRIDGE)) {
> +          actualType == VIR_DOMAIN_NET_TYPE_BRIDGE ||
> +          actualType == VIR_DOMAIN_NET_TYPE_DIRECT)) {
>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                         _("Multiqueue network is not supported for: %s"),
>                         virDomainNetTypeToString(actualType));
> 

ACKed and pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]