[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Libvirt: Add missing default value for config option max_queued_clients



On 29.02.2016 14:33, Jason J. Herne wrote:
> Commit 1199edb1d4e3 added config option max_queued_clients and documented the
> default value as 1000 but never actually set that value. This patch sets the
> default value.
> 
> This addresses an issue whereby the following error message is reported if too
> many migrations are started simultaneously:
> 
> error: End of file while reading data: Ncat: Invalid argument.: Input/output error
> 
> The problem is that too many ncat processes are spawned on the destination
> system. They all attempt to connect to the libvirt socket. Because the
> destination libvirtd cannot respond to the connect requests quickly enough we
> overrun the socket's pending connections queue.
> 
> Signed-off-by: Jason J. Herne <jjherne linux vnet ibm com>
> Reviewed-by: Boris Fiuczynski <fiuczy linux vnet ibm com>
> ---
>  daemon/libvirtd-config.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/daemon/libvirtd-config.c b/daemon/libvirtd-config.c
> index c31c8b2..7a448f9 100644
> --- a/daemon/libvirtd-config.c
> +++ b/daemon/libvirtd-config.c
> @@ -280,6 +280,7 @@ daemonConfigNew(bool privileged ATTRIBUTE_UNUSED)
>      data->min_workers = 5;
>      data->max_workers = 20;
>      data->max_clients = 5000;
> +    data->max_queued_clients = 1000;
>      data->max_anonymous_clients = 20;
>  
>      data->prio_workers = 5;
> 

Oops. ACKed and pushed. Thanks for noticing.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]