[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/4] lxc, libxl: reuse virDomainObjUpdateModificationImpact




On 01.03.2016 18:46, John Ferlan wrote:
> 
> 
> On 02/24/2016 03:38 AM, Nikolay Shirokovskiy wrote:
>> First fortunately all versions of *_CURRENT, *_CONFIG and *_LIVE flags
>> are numerically equal. Second libxl functions that don't use masks
>> for flag expansion forbid extra flags via virCheckFlags before.
>>
>> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy virtuozzo com>
>> ---
>>  src/libxl/libxl_driver.c | 63 ++++------------------------------------
>>  src/lxc/lxc_driver.c     | 75 ++++--------------------------------------------
>>  2 files changed, 12 insertions(+), 126 deletions(-)
>>
> 
> This should be two separate patches and use of singular libxl: and lxc:
> prefixes on the subject line.
> 
> #1 For libxl driver changes (there's a bug there too)
> #2 for lxc changes
> 
> This one I'll ask you to fix the bug and repost as two separate patches
> 

OK. I'll resend soon.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]