[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Check if domain is active in GetControlInfo



On 03/03/16 13:43, Jiri Denemark wrote:
> Reporting status of a control connection makes no sense for an inactive
> domain.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1281706
> 
> Signed-off-by: Jiri Denemark <jdenemar redhat com>
> ---
>  src/qemu/qemu_driver.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 4bd4071..9fd4c57 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -2763,6 +2763,12 @@ qemuDomainGetControlInfo(virDomainPtr dom,
>      if (virDomainGetControlInfoEnsureACL(dom->conn, vm->def) < 0)
>          goto cleanup;
>  
> +    if (!virDomainObjIsActive(vm)) {
> +        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
> +                       _("domain is not running"));
> +        goto cleanup;
> +    }
> +
>      priv = vm->privateData;
>  
>      memset(info, 0, sizeof(*info));
> 

ACK

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]