[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/24] hostdev: Make comments easier to change later



On 03/07/2016 12:24 PM, Andrea Bolognani wrote:
Replace the term "loop" with the more generic "step". This allows us
to be more flexible and eg. have a step that consists in a single
function call.

Don't include the number of steps in the first comment of the
function, so that we can add or remove steps without having to worry
about keeping that comment in sync.

For the same reason, remove the summary contained in that comment.

Clean up some weird vertical spacing while we're at it.
---
  src/util/virhostdev.c | 58 +++++++++++++++++++++++----------------------------
  1 file changed, 26 insertions(+), 32 deletions(-)

ACK.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]