[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 00/21] Various (tiny) clean-ups and changes for daemon/admin



I wanted to make virAdmConnectListAllServers()'s dispatch function
generated by our mighty gendispatch script.  And when doing that I
stumbled upon various other things, changed what seemed better and at
the end I ended up with one huge commit.  Because lot of those changes
should not be done together in one commit, I split each tiny part so
it's nicer to review.  However, some might point out that some commits
do not belong together.  To that I say it was a pain splitting the
commit, don't make me split the series as well, please =)

This "conflicts" with Erik's series that deals with worker threads
tuning.  We about know that and we will merge those together, or
rather rebase on top of each other based on which version of
virAdmConnectLookupServer{,ByName}() you and we like better.


Martin Kletzander (21):
  admin: Make virAdmServerFree() handle NULL gracefully
  admin: Check for flags properly
  server: Store server name in server object
  daemon: Get server name from the server itself
  virerror: Introduce new error type NO_SERVER
  daemon: Set error for unknown server name
  daemon: Properly check for clients
  Expose virNetServerGetName
  admin: Do not work with virAdm on the server side
  Change virNetDaemonGetServerNames to virNetDaemonGetServers
  admin: Don't use priority for admin APIs
  virt-admin: Don't leak uri all over the place
  admin: Be consistent when resetting errors
  gendispatch: Cluster, don't capture if not needed
  gendispatch: Be able to generate multi-return values
  admin: Generate ConnectListServers dispatch helpers
  gendispatch: Accept server as an argument
  admin: Add virAdmConnectLookupServer
  gendispatch: Remember the name of snapshot variable name
  gendispatch: Support modern listing of more types
  remote: Generate what's possible

 daemon/admin.c                  |  49 +--
 daemon/admin_server.c           |  36 +--
 daemon/admin_server.h           |  12 +-
 daemon/libvirtd.c               |  10 +-
 daemon/remote.c                 | 599 ------------------------------------
 include/libvirt/libvirt-admin.h |   4 +
 include/libvirt/virterror.h     |   1 +
 po/POTFILES.in                  |   1 -
 src/admin/admin_protocol.x      |  21 +-
 src/admin/admin_remote.c        |  63 ----
 src/admin_protocol-structs      |   8 +
 src/libvirt-admin.c             |  48 ++-
 src/libvirt_admin_private.syms  |   2 +
 src/libvirt_admin_public.syms   |   1 +
 src/libvirt_remote.syms         |   2 +
 src/locking/lock_daemon.c       |   5 +-
 src/logging/log_daemon.c        |   5 +-
 src/lxc/lxc_controller.c        |   5 +-
 src/remote/remote_driver.c      | 654 ----------------------------------------
 src/remote/remote_protocol.x    |  40 +--
 src/rpc/gendispatch.pl          | 374 +++++++++++++++++------
 src/rpc/virnetdaemon.c          |  65 ++--
 src/rpc/virnetdaemon.h          |   3 +-
 src/rpc/virnetserver.c          |  20 +-
 src/rpc/virnetserver.h          |   6 +-
 src/util/virerror.c             |   6 +
 tests/virnetdaemontest.c        |  10 +-
 tools/virt-admin.c              |   8 +-
 28 files changed, 509 insertions(+), 1549 deletions(-)

--
2.7.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]