[libvirt] [PATCH 16/21] admin: Generate ConnectListServers dispatch helpers

[Martin Kletzander]

On Thu, Mar 10, 2016 at 02:57:39PM +0100, Ján Tomko wrote:
>On Thu, Mar 10, 2016 at 05:54:05AM +0100, Martin Kletzander wrote:
>> Since we have the opportunity now, let's save some precious code lines.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  daemon/admin.c             | 45 ---------------------------------
>>  daemon/admin_server.c      |  6 ++---
>>  daemon/admin_server.h      |  6 ++---
>>  po/POTFILES.in             |  1 -
>>  src/admin/admin_protocol.x |  4 +--
>>  src/admin/admin_remote.c   | 63 ----------------------------------------------
>>  6 files changed, 8 insertions(+), 117 deletions(-)
>>
>
>ACK, beautiful diffstat.
>

Check the stat for the whole series thinking about the fact that this
series adds new things :)

>The new generated version of adminDispatchConnectListServers has
>the following check:
>
>+    if (!priv->dmn) {
>+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("connection not open"));
>+        goto cleanup;
>+    }
>
>Is it dead code or has it been missing in the manual implementation?
>

This is one of the things that this patch "fixed".  That should've been
there before as well.

>Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160310/0d8cc450/attachment-0001.sig>