[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v4 0/2] qemu: add debug-threads support



QEMU (somewhere around 2.0) added a new sub-option to the -name flag
-name debug-threads=on

This causes the naming of individual QEMU threads to be helpful; e.g.
 'CPU/KVM 0' or 'migration' these show up in top once the H key is
 pressed, and also show up in a core dump, making it easy to figure
 out which thread is which.

The following 2 patches add a capability check and enable
debug-threads if supported.

Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1140121

cheers

v3->v4:
- simplify a bit command generation
- added a test

v2->v3:
- move -name command generation in seperate function
- fix syntax-check
- fix leak

v1->v2:
- drop the configuration, enable debug-thread automatically

Marc-André Lureau (2):
  qemu: check for debug-threads capability
  qemu: enable debug threads

 src/qemu/qemu_capabilities.c                       |  2 ++
 src/qemu/qemu_capabilities.h                       |  1 +
 src/qemu/qemu_command.c                            | 34 +++++++++++++++++-----
 tests/qemucapabilitiesdata/caps_2.1.1-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_2.4.0-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_2.5.0-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0-1.caps       |  1 +
 .../qemuxml2argv-debug-threads.args                | 22 ++++++++++++++
 .../qemuxml2argv-debug-threads.xml                 | 34 ++++++++++++++++++++++
 tests/qemuxml2argvtest.c                           |  2 ++
 10 files changed, 91 insertions(+), 8 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-debug-threads.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-debug-threads.xml

-- 
2.5.0


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]