[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH V3 1/2] libxl_conf: reuse virDomainNetGetActualtype in libxlMakeNicList



Chunyan Liu wrote:
> Reuse existing helper function virDomainNetGetActualtype.
> 
> Signed-off-by: Chunyan Liu <cyliu suse com>
> ---
>  src/libxl/libxl_conf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 93c943b..2b77c59 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -1445,7 +1445,8 @@ libxlMakeNicList(virDomainDefPtr def,  libxl_domain_config *d_config)
>          return -1;
>  
>      for (i = 0; i < nnics; i++) {
> -        if (l_nics[i]->type == VIR_DOMAIN_NET_TYPE_HOSTDEV)
> +        if (virDomainNetGetActualType(l_nics[i])
> +            == VIR_DOMAIN_NET_TYPE_HOSTDEV)

This will actually fit within 80 columns on one line. I've made that change and
pushed the patch. Thanks!

Regards,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]