[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [REPOST PATCH 0/8] Reorganize qemu_command.c in smaller piles (round 3)



On Fri, Mar 11, 2016 at 07:36:21PM -0500, John Ferlan wrote:
> Final pile of split.
> 
> Rather than hope for a review of 25 patches or creating some remote
> place to place a branch - I'll repost the original:
> 
> http://www.redhat.com/archives/libvir-list/2016-February/msg00975.html
> 
> in smaller chunks. Differences in this set of patches vs. original series
> includes handling merge conflicts for logManager series plus a few minor
> edits/tweaks for better formatting/flow.  This series was based off of
> git head commit 'ef2ab8fdc' which is the round 1 of the split:
> 
> http://www.redhat.com/archives/libvir-list/2016-March/msg00288.html
> 
> This is round 2 of the split based off of commit id '95ca4fe2':
> 
> http://www.redhat.com/archives/libvir-list/2016-March/msg00491.html
> 
> John Ferlan (8):
>   qemu: Introduce qemuBuildSoundCommandLine
>   qemu: Introduce qemuBuildWatchdogCommandLine
>   qemu: Introduce qemuBuildRedirdevCommandLine
>   qemu: Introduce qemuBuildHostdevCommandLine
>   qemu: Introduce qemuBuildMemballoonCommandLine
>   qemu: Introduce qemuBuildRNGCommandLine
>   qemu: Introduce qemuBuildNVRAMCommandLine
>   qemu: Introduce qemuBuildPanicCommandLine
> 
>  src/qemu/qemu_command.c | 1346 ++++++++++++++++++++++++++---------------------
>  src/qemu/qemu_command.h |   25 +-
>  2 files changed, 743 insertions(+), 628 deletions(-)
> 

ACK series.

However the static function changes could be one separate patch
and the const virDomainDef could be in another one.

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]