On Wed, Mar 16, 2016 at 09:52:31AM +0000, Richard W.M. Jones wrote:
On Tue, Mar 15, 2016 at 05:10:48PM -0400, Cole Robinson wrote:https://bugzilla.redhat.com/show_bug.cgi?id=1271183 We only wait .5 seconds for the session daemon to start up and present its socket, which isn't sufficient for many users. Bump up the sleep interval and retry amount so we wait for a total of 5 seconds.A longer delay is surely better, so ACK from me.
Unless it's half a minute or 20 seconds or whatever it was before as we were getting complaints for that. ACK from me too.
danpb suggests dropping the reverting this: commit be78814ae07f092d9c4e71fd82dd1947aba2f029 Author: Michal Privoznik <mprivozn redhat com> Date: Thu Apr 2 14:41:17 2015 +0200 virNetSocketNewConnectUNIX: Use flocks when spawning a daemonThis commit references: https://bugzilla.redhat.com/show_bug.cgi?id=1200149 The test for that bug is very simple, just run the following command as *NON* root: killall libvirtd ; for i in `seq 1 5`; do virsh list >/tmp/log$i 2>&1 & done If some of the virsh instances fail, then you've hit the bug. Commit be78814a did appear to fix that. Whether that was coincidental or not, I don't know, but please don't reintroduce that bug, particularly as it is so simple to test for. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html -- libvir-list mailing list libvir-list redhat com https://www.redhat.com/mailman/listinfo/libvir-list
Description: Digital signature