[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/3] qemu: Omit SPICE address if no port is specified



On Wed, Mar 16, 2016 at 05:45:04PM +0100, Christophe Fergeau wrote:
> Currently -spice addr=127.0.0.1 is generated, but spice-server is going
> to ignore this as no port is specified.
> ---
>  src/qemu/qemu_command.c                            | 60 +++++++++++-----------
>  .../qemuxml2argv-controller-order.args             |  2 +-
>  2 files changed, 32 insertions(+), 30 deletions(-)
> 

ACK

> -            goto error;
> +        if (!listenAddr)
> +            listenAddr = cfg->spiceListen;
> +        if (listenAddr) {
> +            virBufferAsprintf(&opt, "addr=%s,", listenAddr);
> +        }
>  

This also fails syntax check.

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]