[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 2/2] nodedev: Expose PCI header type




On 03/18/2016 03:28 AM, Martin Kletzander wrote:
> On Thu, Mar 17, 2016 at 12:30:48PM -0400, John Ferlan wrote:
>>
>>
>> On 03/17/2016 12:18 PM, Martin Kletzander wrote:
>>> If we expose this information, which is one byte in every PCI config
>>> file, we let all mgmt apps know whether the device itself is an endpoint
>>> or not so it's easier for them to decide whether such device can be
>>> passed through into a VM (endpoint) or not (*-bridge).
>>>
>>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1317531
>>>
>>> Signed-off-by: Martin Kletzander <mkletzan redhat com>
>>> ---
>>>  docs/schemas/nodedev.rng                           | 11 ++++++++
>>>  src/conf/node_device_conf.c                        | 20 +++++++++++++
>>>  src/conf/node_device_conf.h                        |  1 +
>>>  src/libvirt_private.syms                           |  3 ++
>>>  src/node_device/node_device_udev.c                 |  3 ++
>>>  src/util/virpci.c                                  | 33
>>> ++++++++++++++++++++++
>>>  src/util/virpci.h                                  | 12 ++++++++
>>>  .../pci_0000_00_02_0_header_type.xml               | 15 ++++++++++
>>>  .../pci_0000_00_1c_0_header_type.xml               | 20 +++++++++++++
>>>  tests/nodedevxml2xmltest.c                         |  2 ++
>>>  10 files changed, 120 insertions(+)
>>>  create mode 100644
>>> tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml
>>>  create mode 100644
>>> tests/nodedevschemadata/pci_0000_00_1c_0_header_type.xml
>>>
>>
>> Will there be an adjustment to formatnode.html.in too? To explain how to
>> use...
>>
> 
> Oh, thanks for reminding me of that.  Would squashing something similar
> to this suffice or should I rather repost this as v4?

Squashing is fine - just didn't want it forgotten...  I like the new
formatting too.

ACK as a squash -

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]