[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: Produce predictable results in nsstest




On 03/21/2016 11:33 AM, Michal Privoznik wrote:
> Problem is that in the test any status file matching
> tests/nssdata/*.status is loaded as it contains IP addresses that
> are parsed. However, there's no order specified in which the
> files are loaded. Therefore on different systems the order may be
> different. This is then producing an unexpected results.
> Instead of defining an order in which the files are loaded, make
> the code that checks for missing IP addresses (or redundant ones)
> cope with unordered list of addresses. The reasoning behind is
> that the code doing the parsing is used in real NSS module where
> we don't care for ordering.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  tests/nsstest.c | 25 ++++++++++++-------------
>  1 file changed, 12 insertions(+), 13 deletions(-)
> 

Fixes things for me too...

Thanks -

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]