[libvirt] [PATCH 2/2] hostdev: Stop early if unmanaged devices have not been detached
John Ferlan
jferlan at redhat.com
Tue Mar 22 11:46:16 UTC 2016
On 03/17/2016 01:24 PM, Andrea Bolognani wrote:
> Unmanaged devices, as the name suggests, are not detached
> automatically from the host by libvirt before being attached to a
> guest: it's the user's responsability to detach them manually
> beforehand. If that preliminary step has not been performed, the
> attach operation can't complete successfully.
>
> Instead of relying on the lower layers to error out with cryptic
> messages such as
>
> error: Failed to attach device from /tmp/hostdev.xml
> error: Path '/dev/vfio/12' is not accessible: No such file or directory
>
> prevent the situation altogether and provide the user with a more
> useful error message.
> ---
> src/util/virhostdev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Like noted in 1/2 - I think this needs to be merged into the previous.
Including this commit message.
ACK with that
John
More information about the libvir-list
mailing list