[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/12] qemu_process: introduce qemuProcessPrepareHost



On 03/15/2016 09:16 AM, Pavel Hrdina wrote:
> Move all code that modifies host system to this function.
> 
> Signed-off-by: Pavel Hrdina <phrdina redhat com>
> ---
>  src/qemu/qemu_migration.c |   3 +
>  src/qemu/qemu_process.c   | 191 +++++++++++++++++++++++++---------------------
>  src/qemu/qemu_process.h   |   4 +
>  3 files changed, 113 insertions(+), 85 deletions(-)
> 

ACK patch #4 and #5, but please add docstrings to the functions describing
their purpose so we have more clear guidelines what checks should go where.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]