[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC 0/6] Probe and expose GIC capabilities



On Tue, Mar 22, 2016 at 1:57 PM, Cole Robinson <crobinso redhat com> wrote:
> On 03/21/2016 01:28 PM, Andrea Bolognani wrote:
>> This series implements support for asking QEMU what GIC versions can
>> be used for guests, eg:
>>
>>   <features>
>>     <gic version='2'/>
>>   </features>
>>
>> and exposing such information to users via domain capabilities.
>>
>> QEMU patches that implement the query-gic-capabilities QMP command:
>>
>>   https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg04465.html
>>
>> Cheers.
>>
>>
>> Andrea Bolognani (6):
>>   conf: Get rid of virDomainCapsDevice
>>   qemu: Probe GIC capabilities
>>   schema: Validate GIC capabilities
>>   conf: Expose GIC capabilities
>>   qemu: Fill in GIC capabilities
>>   qemu: Cache GIC capabilities
>>
>
> Code looks good to me but I skimmed it. You labelled this an RFC... are you
> waiting for design comments from other people or should I do a full review?
>

Looking through some of the comments [1] on the previous versions of
the QEMU patch set for the QMP command, it seems one essential thing
to get a lock on would be if the interface is sufficient that the QEMU
code should be merged.

So if you or others can verify that part, then that's more urgent than
fine combing through the libvirt code at this point, in my humble
opinion.

[1]: https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05272.html

Thanks,
-Christoffer


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]