[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 2/5] qemu monitor: add multithread compress parameters accessors



On Fri, Mar 18, 2016 at 15:45:39 +0100, Jiri Denemark wrote:
> On Fri, Mar 04, 2016 at 14:20:55 +0300, Nikolay Shirokovskiy wrote:
> > From: ShaoHe Feng <shaohe feng intel com>
> > 
> > Signed-off-by: ShaoHe Feng <shaohe feng intel com>
> > Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy virtuozzo com>
> > ---
> >  src/qemu/qemu_monitor.c      |  22 +++++++++
> >  src/qemu/qemu_monitor.h      |  17 +++++++
> >  src/qemu/qemu_monitor_json.c | 110 +++++++++++++++++++++++++++++++++++++++++++
> >  src/qemu/qemu_monitor_json.h |   5 ++
> >  4 files changed, 154 insertions(+)
> > 
> > diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
> > index 5e4461a..21c1df6 100644
> > --- a/src/qemu/qemu_monitor.c
> > +++ b/src/qemu/qemu_monitor.c

[...]

> > diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
> > index 28620b5..b28b431 100644
> > --- a/src/qemu/qemu_monitor.h
> > +++ b/src/qemu/qemu_monitor.h
> > @@ -469,6 +469,23 @@ int qemuMonitorGetMigrationCacheSize(qemuMonitorPtr mon,
> >  int qemuMonitorSetMigrationCacheSize(qemuMonitorPtr mon,
> >                                       unsigned long long cacheSize);
> >  
> > +typedef struct _qemuMonitorMigrationParameters qemuMonitorMigrationParameters;
> > +typedef qemuMonitorMigrationParameters *qemuMonitorMigrationParametersPtr;
> > +struct _qemuMonitorMigrationParameters {
> > +    unsigned int level_set : 1;
> > +    unsigned int threads_set : 1;
> > +    unsigned int dthreads_set : 1;

Also booleans are preferred in comparison to this approach.

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]