[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [ 2/3] allow to specify peer to ip element in domain network



On 03/23/2016 08:03 AM, Daniel P. Berrange wrote:
On Fri, Mar 18, 2016 at 10:19:42PM +0000, Vasiliy Tolstov wrote:
this allows user to specify destination address for ip like tunnel

Signed-off-by: Vasiliy Tolstov <v tolstov selfip ru>
---
  docs/schemas/interface.rng | 6 ++++++
  1 file changed, 6 insertions(+)
The RNG schema changes are usually associated with the parser changes.
IOW, this patch should contain these changes

  src/conf/domain_conf.c           | 14 ++++++++++++-
  src/conf/domain_conf.h           |  1 +
  src/conf/network_conf.c          | 26 +++++++++++++++++++++++-
  src/conf/network_conf.h          |  1 +


from your 3rd patch. The 3rd patch should just contain the code for
doing the host OS setup / integration.

Actually interface.rng is only for the virInterface APIs, so it shouldn't be touched at all for any of this. Any change to interface.rng would be paired with a change to interface_conf.c and to the netcf package that virInterface uses as its backend.

The RNG for something related to an IP address in the libvirt virtual network xml would be in network.rng or networkcommon.rng, and that for an IP address in the domain would be in domaincommon.rng or networkcommon.rng.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]