[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] virlog: Refactor logging filters parser



On 24/03/16 15:43, Michal Privoznik wrote:
> On 18.03.2016 10:07, Erik Skultety wrote:
>> This series continues where series 0b231195 left and refactors logging filter
>> parser. Series 0b231195 also introduced a small bug where if a specific
>> testcase passes, but should fail, the original parser return value is returned
>> instead of -1. That way, the virlogtest as a whole still appears as passed,
>> even though it failed. Thus, this series also addresses this issue.
>>
>> Erik Skultety (3):
>>   tests: virlogtest: Fix testLogParseOutputs return value
>>   tests: Add new testcases to test parsing of log filters in virlogtest
>>   virlog: Refactor virLogParseFilters
>>
>>  src/util/virlog.c  | 95 +++++++++++++++++++++++++++++++++++++-----------------
>>  tests/virlogtest.c | 50 +++++++++++++++++++++++++---
>>  2 files changed, 111 insertions(+), 34 deletions(-)
>>
> 
> ACK series.
> 
> Michal
> 

Adjusted 2/3 and pushed the series.
Thank you for review.

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]