[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: revert bogus raw volumes support check



  John Ferlan wrote:

> 
> 
> On 03/26/2016 01:10 PM, Roman Bogorodskiy wrote:
> > Commits bb5f2dc and 6682d62 added a check like:
> > 
> >   if (vol->target.format != VIR_STORAGE_FILE_RAW)
> > 
> > to the CreateVol method for zfs and logical storage backends
> > respectively. However, this check is bogus because
> > virStorageVolDefParseXML() in conf/storage_conf.c sets target.format
> > only if volOptions in virStoragePoolTypeInfo has formatFromString set,
> > and that's not the case for zfs and logical backends. So the check
> > always fails and breaks volume creation.
> > 
> > Thus, revert those commits.
> > ---
> >  src/storage/storage_backend_logical.c | 6 ------
> >  src/storage/storage_backend_zfs.c     | 6 ------
> >  2 files changed, 12 deletions(-)
> > 
> 
> ACK - although I redid it slightly to use the git revert command and
> adjusting the commit ...

Great, thanks!

I used git revert as well, but then decided that I'm lazy to write
almost the same commit message twice and squashed that into one.

Roman Bogorodskiy

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]